Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEFT]fix lora model tp when existing other trainable module #7781

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

lugimzzz
Copy link
Contributor

@lugimzzz lugimzzz commented Jan 4, 2024

PR types

Bug fixes

PR changes

APIs

Description

修复lora tp时除了lora参数外其他可训练参数报错

Copy link

paddle-bot bot commented Jan 4, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5c7efcc) 57.30% compared to head (95ef3f1) 57.42%.
Report is 5 commits behind head on develop.

Files Patch % Lines
paddlenlp/peft/lora/lora_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7781      +/-   ##
===========================================
+ Coverage    57.30%   57.42%   +0.11%     
===========================================
  Files          584      585       +1     
  Lines        87688    87975     +287     
===========================================
+ Hits         50252    50519     +267     
- Misses       37436    37456      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 079f067 into PaddlePaddle:develop Jan 8, 2024
9 of 10 checks passed
@lugimzzz lugimzzz deleted the peftfix branch January 10, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants