Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unified checkpoint] fix checkpoint names #7794

Merged

Conversation

DrownFish19
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Description

  1. save master weights name as model weights name when SKIP_SAVE_MODEL_WEIGHT.
  2. fix config save skip when SKIP_SAVE_MODEL_WEIGHT.

change master weigths name to model weigths name when SKIP_SAVE_MODEL_WEIGHT
Copy link

paddle-bot bot commented Jan 8, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (0658258) 57.30% compared to head (c78b1d9) 57.30%.
Report is 3 commits behind head on release/2.7.

Files Patch % Lines
paddlenlp/trainer/plugins/unified_checkpoint.py 3.03% 32 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.7    #7794      +/-   ##
===============================================
- Coverage        57.30%   57.30%   -0.01%     
===============================================
  Files              584      584              
  Lines            87688    87702      +14     
===============================================
+ Hits             50252    50255       +3     
- Misses           37436    37447      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

when skipping model weighs save and saving master weights as model weights, unified checkpoint needs choose the model weights to load into master weights.
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 672ee98 into PaddlePaddle:release/2.7 Jan 8, 2024
5 of 7 checks passed
@DrownFish19 DrownFish19 deleted the dev_unified_checkpoint_release_2.7 branch January 9, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants