[CI] add ci approval pipelines #7859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7859 +/- ##
===========================================
- Coverage 56.91% 56.68% -0.23%
===========================================
Files 587 588 +1
Lines 88740 89243 +503
===========================================
+ Hits 50502 50584 +82
- Misses 38238 38659 +421 ☔ View full report in Codecov by Sentry. |
wj-Mcat
reviewed
Jan 18, 2024
| elif [[ ${dir1} =~ "paddlenlp" ]];then | ||
| if [[ ${dir2} =~ "transformers" ]];then | ||
| echo_line="You must have one RD (wawltor) approval for the changes of `transformers` " | ||
| check_approval 1 sijunhe wawltor |
There was a problem hiding this comment.
这里先将 sijun 移除掉吧，下面也是需要删掉的。
| echo_line="You must have one RD (ZHUI, wawltor,ForFishes,sneaxiy,zhiqiu) approval for the changes of `model_zoo/gpt-3` " | ||
| check_approval 1 ZHUI wawltor ForFishes sneaxiy zhiqiu | ||
| fi | ||
| elif [[ ${dir1} =~ "llm" ]];then |
There was a problem hiding this comment.
llm 目录下其他模块有多个人同时在调整，你就设置: wj-Mcat/lugimzzz/DesmonDay/wawltor
ZHUI
reviewed
Jan 19, 2024
| dir2=${arr_file_name[1]} | ||
| dir3=${arr_file_name[2]} | ||
| dir4=${arr_file_name[3]} | ||
| echo "file_name:"${file_name}, "dir1:"${dir1}, "dir2:"${dir2},"dir3:"${dir3},".xx:" ${file_name##*.} |
There was a problem hiding this comment.
这个 脚本搞得 太复杂了，用python 对写的配置文件判断好了。
后面大家只要删减配置文件里面的东西。程序和内容分离。
现在修改改起来也特别麻烦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Description