Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Features] Trainer add Wandb and Tensorboard #7863

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

greycooker
Copy link
Contributor

@greycooker greycooker commented Jan 18, 2024

PR types

New Features

PR changes

Trainer

Description

Trainer integrate TensorBoard and Weights & Biases (wandb)

Wandb pictures
image
image

Tensorboard pictures
image
image

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (c9d22db) 56.96% compared to head (e466aa5) 56.78%.
Report is 6 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/integrations.py 69.86% 44 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7863      +/-   ##
===========================================
- Coverage    56.96%   56.78%   -0.18%     
===========================================
  Files          587      588       +1     
  Lines        88647    89390     +743     
===========================================
+ Hits         50494    50759     +265     
- Misses       38153    38631     +478     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gongel gongel requested a review from ZHUI January 18, 2024 12:54
@@ -18,6 +18,10 @@

import importlib
import json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr 描述里面,描述一下 使用出来的效果,截图展示一下?

注意同步修改一下中文文档 https://github.com/PaddlePaddle/PaddleNLP/blob/develop/docs/trainer.md

paddlenlp/trainer/training_args.py Show resolved Hide resolved
paddlenlp/trainer/training_args.py Show resolved Hide resolved
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 0d6fc1e into PaddlePaddle:develop Jan 31, 2024
8 of 10 checks passed
@greycooker greycooker deleted the add_wandb_and_tensorboard branch August 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants