Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] fix llama precision on custom devices #7895

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

SylarTiaNII
Copy link
Contributor

PR types

Bug fixes

PR changes

Models

Description

Remove redundant type casting on masked_lm_loss which may cause precision failures on custom devices

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (13fd655) 56.68% compared to head (998a1a7) 56.68%.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7895   +/-   ##
========================================
  Coverage    56.68%   56.68%           
========================================
  Files          588      588           
  Lines        89352    89352           
========================================
+ Hits         50651    50653    +2     
+ Misses       38701    38699    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 95c0dd4 into PaddlePaddle:develop Jan 26, 2024
8 of 10 checks passed
Copy link

paddle-bot bot commented Feb 4, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants