Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【AutoParallelism】fix dataloader bug and add ci for static #8014

Merged
merged 11 commits into from
Mar 4, 2024

Conversation

heavyrain-lzy
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy commented Feb 23, 2024

PR types

Bug fixes

PR changes

Others

Description

Fix the wrong usage of shard_dataloader.

Copy link

paddle-bot bot commented Feb 23, 2024

Thanks for your contribution!

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.55%. Comparing base (dff7dcc) to head (123be7a).
Report is 5 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8014      +/-   ##
===========================================
+ Coverage    56.42%   56.55%   +0.12%     
===========================================
  Files          589      592       +3     
  Lines        90252    91055     +803     
===========================================
+ Hits         50921    51492     +571     
- Misses       39331    39563     +232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhiqiu
zhiqiu previously approved these changes Feb 27, 2024
Copy link
Collaborator

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZHUI
ZHUI previously approved these changes Mar 1, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 17cc169 into PaddlePaddle:develop Mar 4, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants