-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoRA] add quick_lora #8106
[LoRA] add quick_lora #8106
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8106 +/- ##
===========================================
- Coverage 55.44% 55.41% -0.03%
===========================================
Files 596 597 +1
Lines 91464 91587 +123
===========================================
+ Hits 50713 50754 +41
- Misses 40751 40833 +82 ☔ View full report in Codecov by Sentry. |
…t be set to True to prevent any potential errors from occurring.
冲突了 |
input_grad = None | ||
|
||
if not input.stop_gradient: | ||
input_grad = paddle.addmm( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
求input_grad是不是可以考虑使用merged_weight,input_grad= paddle.matmul(grad_output, merged_weight, transpose_y=True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged_weight这个东西没法从前向复用,复用会占用很大的显存。
然后如果合并计算的话,就无法复用 lora_B_input_grad = paddle.matmul(grad_output, lora_B, transpose_y=True)。需要重新计算一次
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR types
New features
PR changes
APIs
Description
已知缺陷: