Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Fix sharding overlap bug #8333

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

If enable_sharding_comm_overlap in pipeline_parallel_configs, amp_master_grad must be True.

Copy link

paddle-bot bot commented Apr 26, 2024

Thanks for your contribution!

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.36%. Comparing base (a37f53d) to head (c63eb00).

Files Patch % Lines
paddlenlp/trainer/training_args.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8333      +/-   ##
===========================================
- Coverage    55.37%   55.36%   -0.01%     
===========================================
  Files          613      613              
  Lines        95870    95872       +2     
===========================================
  Hits         53084    53084              
- Misses       42786    42788       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 7c3ab53 into PaddlePaddle:develop Apr 28, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants