change llama/modeling.py to opt npu performence #8342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wawltor
reviewed
Apr 29, 2024
| # masked_lm_loss = masked_lm_loss[masked_lm_loss > 0] | ||
| # loss = paddle.mean(masked_lm_loss) | ||
| binary_sequence = paddle.where(masked_lm_loss > 0, paddle.ones_like(masked_lm_loss), paddle.zeros_like(masked_lm_loss)) | ||
| loss = paddle.sum(masked_lm_loss * binary_sequence) / paddle.sum(binary_sequence) |
There was a problem hiding this comment.
paddle.sum(binary_sequence) 中binary_sequence有可能全为0，导致sum后0；这里loss会有异常
之前的业务遇到过这个问题
ZHUI
reviewed
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Models
Description
优化NPU下跑llama模型时使用is_casual_mask 对ppt, lora ,sft策略选择问题