Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix fast tokenizer import error #8367

Merged
merged 2 commits into from
May 9, 2024
Merged

[Bugfix] Fix fast tokenizer import error #8367

merged 2 commits into from
May 9, 2024

Conversation

w5688414
Copy link
Contributor

@w5688414 w5688414 commented May 7, 2024 •
edited
Loading

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 7, 2024

Thanks for your contribution!

@w5688414 w5688414 requested a review from ZHUI May 7, 2024 02:34
@w5688414 w5688414 mentioned this pull request May 7, 2024
Closed
1 task
ZHUI
ZHUI approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.36%. Comparing base (0f45875) to head (a40ca40).
Report is 2 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/auto/tokenizer.py 63.63% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8367      +/-   ##
===========================================
- Coverage    55.37%   55.36%   -0.01%     
===========================================
  Files          614      614              
  Lines        96015    96022       +7     
===========================================
+ Hits         53164    53167       +3     
- Misses       42851    42855       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@w5688414 w5688414 self-assigned this May 7, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators May 8, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation May 8, 2024
@wawltor wawltor merged commit eeafb21 into PaddlePaddle:develop May 9, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

Assignees

@w5688414 w5688414

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: module 'paddlenlp.transformers.ernie.tokenizer' has no attribute 'ErnieFastTokenizer'
3 participants
@w5688414 @ZHUI @wawltor