Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ckpt done #8402

Merged
merged 1 commit into from
May 11, 2024
Merged

Fix ckpt done #8402

merged 1 commit into from
May 11, 2024

Conversation

gongel
Copy link
Member

@gongel gongel commented May 9, 2024

PR types

  • Bug fixes

PR changes

  • APIs

Description

  • checkpoint_done原先会被存两次,AFS不支持追加写,导致失败。现将ckpt和最后保存的模型分开标识。

Copy link

paddle-bot bot commented May 9, 2024

Thanks for your contribution!

@gongel gongel mentioned this pull request May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.42%. Comparing base (6b3875c) to head (cc8ab87).
Report is 6 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8402   +/-   ##
========================================
  Coverage    55.42%   55.42%           
========================================
  Files          615      615           
  Lines        96235    96235           
========================================
  Hits         53335    53335           
  Misses       42900    42900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 29d40e2 into PaddlePaddle:develop May 11, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants