-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix npu sft ckpt load bug and no FA bug #8438
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8438 +/- ##
===========================================
- Coverage 55.42% 55.42% -0.01%
===========================================
Files 617 617
Lines 96281 96286 +5
===========================================
+ Hits 53366 53367 +1
- Misses 42915 42919 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
llm/finetune_generation.py
Outdated
model_config.attention_probs_dropout_prob = model_args.attention_probs_dropout_prob | ||
|
||
model_config.sep_parallel_degree = training_args.sep_parallel_degree | ||
model_config.tensor_parallel_output = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个我们好像加了开关的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
NINGBENZHE seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Bug fixes
PR changes
Others
Description
fix npu sft ckpt load bug and no FA bug