Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ New features]Trainer support dict parameter #8446

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

greycooker
Copy link
Contributor

@greycooker greycooker commented May 15, 2024

PR types

New features

PR changes

Trainer support dict parameter

Description

how to pass:
cmd line: --dict_parameter '{dict_value}'
json file: "dict_parameter":dict_value

Copy link

paddle-bot bot commented May 15, 2024

Thanks for your contribution!

@greycooker greycooker changed the title [ New features]Trainer support json parameter [ New features]Trainer support dict parameter May 15, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.96%. Comparing base (5da340e) to head (cf2c5be).
Report is 201 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/argparser.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8446      +/-   ##
===========================================
- Coverage    55.42%   53.96%   -1.47%     
===========================================
  Files          617      648      +31     
  Lines        96281   110989   +14708     
===========================================
+ Hits         53366    59890    +6524     
- Misses       42915    51099    +8184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 6, 2024

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added stale and removed stale labels Aug 6, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 14, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 14, 2024
@wawltor wawltor merged commit 85fbe52 into PaddlePaddle:develop Aug 14, 2024
10 of 12 checks passed
@greycooker greycooker deleted the support_json_parameter branch August 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants