-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sharding V1 broadcast and V2 allgather overlap optimize #8499
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8499 +/- ##
===========================================
- Coverage 54.25% 53.97% -0.29%
===========================================
Files 617 618 +1
Lines 96368 96825 +457
===========================================
- Hits 52288 52259 -29
- Misses 44080 44566 +486 ☔ View full report in Codecov by Sentry. |
update use_casual_mask env
… into sharding_overlap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Performance optimization
PR changes
Others
Description
1、sharding 支持 broadcast overlap forward, allgather overlap forward
2、同时为sharding stage1 overlap优化添加一些约束项
allgather优化只针对stage1 v2
broadcast overlap优化只针对stage1 v1
logging_step必须大于1
使用Use_Casual_mask环境变量避免DToH的sync