[bug fix] fix sharding stage1 allgather overlap bug, which needs to forbiden pin memory #8594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8594 +/- ##
===========================================
- Coverage 54.42% 54.40% -0.02%
===========================================
Files 632 632
Lines 99451 99495 +44
===========================================
+ Hits 54129 54134 +5
- Misses 45322 45361 +39 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Jun 13, 2024
iosmers
force-pushed
the
fix_stage1_overlap_forbiden_pin_mem
branch
from
d1613ac to
45f6314
Compare
ZHUI
reviewed
Jun 13, 2024
| if ( | ||
| "enable_stage1_allgather_overlap" in training_args.sharding_parallel_config | ||
| or "enable_stage1_broadcast_overlap" in training_args.sharding_parallel_config | ||
| ): |
There was a problem hiding this comment.
from paddle.io.reader import use_pinned_memory
import 也改到这里吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
1、sharding stage overlap不能正确生效，原因是没有禁用pin memory
2、必须使用paddle.io.reader 里的 use_pinned_memory， paddle.io.base里面的use_pinned_memory(False)无法生效，原因未知