Update PaddleNLP to fix PPO #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8618 +/- ##
===========================================
- Coverage 54.42% 54.41% -0.01%
===========================================
Files 632 632
Lines 99481 99482 +1
===========================================
- Hits 54140 54132 -8
- Misses 45341 45350 +9 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Jun 19, 2024
| @@ -1687,8 +1687,8 @@ def _load_pretrained_model( | |||
| model: PretrainedModel, | |||
| state_dict: Dict[str, Tensor], | |||
| loaded_keys: List[str], | |||
| resolved_archive_file: Union[str, List], | |||
| pretrained_model_name_or_path, | |||
There was a problem hiding this comment.
原本是没有这些参数的，这个主要是为了兼容老的写法。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Fix some incompatible updates in PaddleNLP to fix PPO.