[Inference LLM] refine some code in llama wint8/4 #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8796 +/- ##
===========================================
+ Coverage 55.03% 55.51% +0.48%
===========================================
Files 627 626 -1
Lines 98921 98057 -864
===========================================
- Hits 54440 54438 -2
+ Misses 44481 43619 -862 ☔ View full report in Codecov by Sentry. |
yuanlehome
changed the title
yuanlehome
commented
Jul 23, 2024
| @@ -104,7 +67,6 @@ def main(): | |||
|
|
|||
| if tensor_parallel_degree > 1: | |||
| export_args.output_path = os.path.join(export_args.output_path, f"rank_{tensor_parallel_rank}") | |||
| validate_pdmodel(export_args.output_path, predictor_args.model_prefix, predictor_args.device) | |||
There was a problem hiding this comment.
这个执行的时候会需要更多的显存，极限场景下会导致爆显存。并且并无实质性的作用，故删除之。
DesmonDay
reviewed
Jul 23, 2024
| @@ -789,11 +788,8 @@ def set_state_dict(self, state_dict): | |||
| qkv_weight_tensor = paddle.to_tensor(concated_qkv_weight) | |||
| qkv_weight_tensor = paddle.transpose(qkv_weight_tensor, perm=[1, 0]) | |||
| qkv_quanted_weight_tensor, qkv_weight_scale_tensor = weight_quantize( | |||
| qkv_weight_tensor.cuda(), algo=self.quant_type | |||
There was a problem hiding this comment.
改动前的逻辑是错误的，wint4 ci并无监控
|
LGTM，建议后面针对 wint4 增加 CI 监控。 |
依赖一个Paddle PR的合入，合入后再添加～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
refine some code in llama wint8/4