fix pad_token_id bug #8814
Merged
fix pad_token_id bug #8814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8814 +/- ##
===========================================
- Coverage 55.52% 55.51% -0.02%
===========================================
Files 630 631 +1
Lines 98365 99128 +763
===========================================
+ Hits 54619 55032 +413
- Misses 43746 44096 +350 ☔ View full report in Codecov by Sentry. |
yuanlehome
commented
Jul 26, 2024
| @@ -1270,7 +1272,7 @@ def create_predictor( | |||
|
|
|||
| # TODO(wj-Mcat): fix llama tokenzier pad_token bug | |||
| if (isinstance(tokenizer, (LlamaTokenizer, Llama3Tokenizer))) and not tokenizer.pad_token: | |||
| tokenizer.pad_token = tokenizer.bos_token | |||
| tokenizer.pad_token = tokenizer.eos_token | |||
yuanlehome
commented
Jul 26, 2024
| logger.warning( | ||
| "Setting `pad_token_id` to `eos_token_id`:{} for " "open-end generation.".format(eos_token_id) | ||
| ) | ||
| if isinstance(eos_token_id, list): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Models
Description
fix pad_token_id bug.