[Inference LLM] support static c8 #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8833 +/- ##
===========================================
+ Coverage 55.44% 55.49% +0.05%
===========================================
Files 631 631
Lines 98542 98554 +12
===========================================
+ Hits 54632 54697 +65
+ Misses 43910 43857 -53 ☔ View full report in Codecov by Sentry. |
DrownFish19
reviewed
Jul 30, 2024
| @@ -435,7 +435,7 @@ def __init__(self, config: LlamaConfig): | |||
| ffn1_bias_attrs = None | |||
| ffn2_bias_attrs = None | |||
|
|
|||
| if self.quant_type == "a8w8": | |||
| if "a8w8" in self.quant_type: | |||
There was a problem hiding this comment.
self.quant_type如果使用in进行字符串判断，有没有位置给出quant_type的全部内容，方便后续开发
There was a problem hiding this comment.
这一块没问题的，留有后续可扩展的位置，比如quant_type全部可能的值是a_w_c_，_表示数字
| self.weight_only_quant_bits = config.weight_only_quant_bits | ||
|
|
||
| if self.quant_type is not None and "weight_only_int" in self.quant_type: | ||
| if config.quant_type == "weight_only_int8": |
There was a problem hiding this comment.
这里是不是能判断weight_only是否在字符串内，实现判断？命名方式是否有具体文档说明？
yuanlehome
force-pushed
the
support_static_c8
branch
from
26686ad to
e358ce3
Compare
DrownFish19
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Models
Description
support static c8