Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick]fix pipeline eval #8924

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

gongel
Copy link
Member

@gongel gongel commented Aug 12, 2024

PR types

Bug fixes

PR changes

Others

Description

  • When do_train=False, do_eval=True, we need to wrap model for pipeline

Copy link

paddle-bot bot commented Aug 12, 2024

Thanks for your contribution!

@gongel gongel requested a review from ZHUI August 12, 2024 09:23
@gongel gongel changed the title fix pipeline eval [Cherry-pick]fix pipeline eval Aug 12, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.12%. Comparing base (30fc639) to head (932637f).
Report is 233 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8924      +/-   ##
===========================================
+ Coverage    55.05%   55.12%   +0.06%     
===========================================
  Files          635      635              
  Lines        99404    99406       +2     
===========================================
+ Hits         54724    54793      +69     
+ Misses       44680    44613      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI merged commit 01bb1f8 into PaddlePaddle:develop Aug 14, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants