[LLM Inference] support llama3.1 #8929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8929 +/- ##
===========================================
+ Coverage 55.05% 55.11% +0.06%
===========================================
Files 635 635
Lines 99410 99548 +138
===========================================
+ Hits 54729 54870 +141
+ Misses 44681 44678 -3 ☔ View full report in Codecov by Sentry. |
DesmonDay
reviewed
Aug 14, 2024
| self.vocab_size, | ||
| self.hidden_size, | ||
| ) | ||
| self.embed_tokens = nn.Embedding(self.vocab_size, self.hidden_size) |
There was a problem hiding this comment.
多卡推理遇到两个问题，1. block_attn为false时动转静会报错，2. block_attn为true时运行会报错
|
建议后续针对 Embedding TP切分的推理报错进行修复，而不是直接改成不切分。 @yuanlehome |
收到，已记todo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
support llama3.1 --block_attn 支持多卡推理