[Unified Checkpoint] Fix load best checkpoint #8935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
DesmonDay
force-pushed
the
fix_uc_load_best
branch
from
607be60
to
2097916
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8935 +/- ##
===========================================
+ Coverage 55.05% 55.07% +0.01%
===========================================
Files 635 635
Lines 99412 99452 +40
===========================================
+ Hits 54730 54771 +41
+ Misses 44682 44681 -1 ☔ View full report in Codecov by Sentry. |
DesmonDay
force-pushed
the
fix_uc_load_best
branch
from
d1d7bc1
to
6f2b814
Compare
ZHUI
reviewed
Aug 15, 2024
| @@ -1203,6 +1206,8 @@ def _load_best_model_from_peft_checkpoint(self): | |||
| self.state.best_model_checkpoint, | |||
| safe_serialization=True, | |||
| ) | |||
| if self.args.sharding_parallel_degree > 1 or self.args.data_parallel_degree > 1: | |||
There was a problem hiding this comment.
这个是不是只需要 peft 相关的参数广播啊，这样是不是所有参数广播？
Mangodadada
pushed a commit
to Mangodadada/PaddleNLP
that referenced
this pull request
Sep 10, 2024
* fix load best * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Fix loading best checkpoint.