Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeroPadding] padding to max_length for sequence parallel #8973

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

DrownFish19
Copy link
Collaborator

PR types

Function optimization

PR changes

Others

Description

This PR addresses the issue where zero padding packs input_ids into a new sequence with varying lengths, which may not be divisible by tensor_parallel_degree. It enables padding the sequence to max_length with a fixed length.

Copy link

paddle-bot bot commented Aug 20, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 54.86%. Comparing base (0136312) to head (a41d87b).
Report is 3 commits behind head on develop.

Current head a41d87b differs from pull request most recent head a4b0264

Please upload reports for the commit a4b0264 to get more accurate results.

Files Patch % Lines
paddlenlp/datasets/zero_padding_dataset.py 13.63% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8973      +/-   ##
===========================================
+ Coverage    54.80%   54.86%   +0.05%     
===========================================
  Files          647      647              
  Lines       102462   102475      +13     
===========================================
+ Hits         56157    56223      +66     
+ Misses       46305    46252      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrownFish19 DrownFish19 reopened this Aug 21, 2024
Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 30a2ac6 into PaddlePaddle:develop Aug 21, 2024
12 of 14 checks passed
@DrownFish19 DrownFish19 deleted the dev_20240820_fix_zero_padding branch August 21, 2024 07:23
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants