Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] fix skip consumed_samples twice bug #8980

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

zhangyuqin1998
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

自动并行下,从checkpoint热启时数据流错乱。因为重复跳过了在DistributedBatchSampler中已经跳过多数据。若DistributedBatchSampler中已对consumed_samples进行了处理,在trainer就不应该重复处理。

Copy link

paddle-bot bot commented Aug 21, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.78%. Comparing base (dd909d1) to head (be5121e).
Report is 220 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8980      +/-   ##
===========================================
- Coverage    54.86%   54.78%   -0.08%     
===========================================
  Files          647      647              
  Lines       103342   102502     -840     
===========================================
- Hits         56699    56160     -539     
+ Misses       46643    46342     -301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 56dba6d into PaddlePaddle:develop Aug 22, 2024
8 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants