Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Checkpoint] Update async save info #8982

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Update async save information.

Copy link

paddle-bot bot commented Aug 21, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.14%. Comparing base (dd909d1) to head (d76d9e6).
Report is 249 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 35.71% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8982      +/-   ##
===========================================
- Coverage    54.86%   53.14%   -1.73%     
===========================================
  Files          647      652       +5     
  Lines       103342   107964    +4622     
===========================================
+ Hits         56699    57376     +677     
- Misses       46643    50588    +3945     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 5956822 into PaddlePaddle:develop Aug 29, 2024
9 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* [Unified checkpoint] update optimizer async save signal

* [Unified Checkpoint] Update async save info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants