Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bos download #9023

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix bos download #9023

merged 3 commits into from
Sep 2, 2024

Conversation

westfish
Copy link
Contributor

PR types

Bug fixes

PR changes

Description

修复不支持subfolder download的bug, 如下:
image

Copy link

paddle-bot bot commented Aug 28, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.84%. Comparing base (a2f9558) to head (9a29c96).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9023      +/-   ##
===========================================
- Coverage    54.24%   53.84%   -0.41%     
===========================================
  Files          650      652       +2     
  Lines       104307   104531     +224     
===========================================
- Hits         56583    56282     -301     
- Misses       47724    48249     +525     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JunnYu
JunnYu previously approved these changes Aug 28, 2024
@JunnYu
Copy link
Member

JunnYu commented Aug 28, 2024

Path(lock_path).parent.mkdir(parents=True, exist_ok=True)
在这里加个一样的也行

Path(cache_path).parent.mkdir(parents=True, exist_ok=True)

Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westfish westfish merged commit 116841a into PaddlePaddle:develop Sep 2, 2024
10 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* fix bos download

* add test

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants