Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ring_flash_attention warning #9119

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

DrownFish19
Copy link
Collaborator

PR types

Others

PR changes

Others

Description

remove the ring_flash_attention warning.

Copy link

paddle-bot bot commented Sep 10, 2024

Thanks for your contribution!

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.33%. Comparing base (d245d07) to head (2fa00fc).
Report is 240 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/ring_flash_attention.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9119      +/-   ##
===========================================
- Coverage    53.47%   53.33%   -0.14%     
===========================================
  Files          652      652              
  Lines       105401   105401              
===========================================
- Hits         56362    56217     -145     
- Misses       49039    49184     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrownFish19 DrownFish19 changed the title fix remove ring_flash_attention warning Sep 10, 2024
@DrownFish19 DrownFish19 changed the title remove ring_flash_attention warning Remove ring_flash_attention warning Sep 10, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 11252bc into PaddlePaddle:develop Sep 13, 2024
7 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_20240910_fix_warning branch September 14, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants