Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Checkpoint] update async_save_info in develop #9173

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Overwrite async_save_info.json file to fit the change of world_size.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (cd4e816) to head (5e1c691).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9173      +/-   ##
===========================================
- Coverage    53.06%   53.05%   -0.01%     
===========================================
  Files          656      656              
  Lines       106147   106147              
===========================================
- Hits         56324    56318       -6     
- Misses       49823    49829       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay DesmonDay force-pushed the develop branch 3 times, most recently from 08e63ed to c44d385 Compare September 23, 2024 16:37
@DesmonDay DesmonDay changed the title [Unified Checkpoint] update async_save_info [Unified Checkpoint] update async_save_info in develop Sep 23, 2024
@ZHUI ZHUI merged commit 31e47a5 into PaddlePaddle:develop Sep 26, 2024
7 of 12 checks passed
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Oct 16, 2024
DesmonDay added a commit that referenced this pull request Oct 16, 2024
* [Unified Checkpoint] Support expert parallel (#9055)

* update code

* [Unified Checkpoint] Fix generation config save (#9223)

* [Unified Checkpoint] update async_save_info in develop (#9173)

* [Unified Checkpoint] update async save logic (#9274)

* update async save signal

* fix async save hang

* bug fix

---------

Co-authored-by: Weiguo Zhu <DrownFish19@gmail.com>
wawltor pushed a commit that referenced this pull request Oct 17, 2024
* [Unified Checkpoint] Support expert parallel (#9055)

* update code

* [Unified Checkpoint] Fix generation config save (#9223)

* [Unified Checkpoint] update async_save_info in develop (#9173)

* [Unified Checkpoint] update async save logic (#9274)

* update async save signal

* fix async save hang

* bug fix

* bug fix

* [Trainer] fix save_model (#9286)

* bug fix

* bug fix

---------

Co-authored-by: Weiguo Zhu <DrownFish19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants