Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] update tensor and pipeline parallel for chatglmv2 #9204

Merged
merged 23 commits into from
Dec 11, 2024

Conversation

DrownFish19
Copy link
Collaborator

@DrownFish19 DrownFish19 commented Sep 26, 2024

PR types

Bug fixes

PR changes

Models

Description

fix tensor parallel for chatglmv2. This is a duplicate of #9133 and #9043.

  1. output_layer中weight切分需要设置self.weight.is_distributed属性。
  2. add pipeline parallel for chatglmv2

@DrownFish19 DrownFish19 force-pushed the dev_20240926_update_chatglmv2 branch from 0fd406b to a2b8a78 Compare September 26, 2024 07:39
@DrownFish19 DrownFish19 reopened this Sep 26, 2024
@DrownFish19 DrownFish19 changed the title [LLM] Fix tensor parallel for chatglmv2 [LLM] update tensor and pipeline parallel for chatglmv2 Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 132 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (753436a) to head (9e9e213).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/chatglm_v2/modeling_pp.py 21.33% 118 Missing ⚠️
paddlenlp/transformers/chatglm_v2/modeling.py 71.42% 12 Missing ⚠️
...p/experimental/transformers/chatglm_v2/modeling.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9204      +/-   ##
===========================================
- Coverage    52.97%   52.80%   -0.17%     
===========================================
  Files          703      705       +2     
  Lines       110981   110947      -34     
===========================================
- Hits         58788    58589     -199     
- Misses       52193    52358     +165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI self-requested a review September 30, 2024 03:44
@ZHUI ZHUI merged commit 45eeac7 into PaddlePaddle:develop Dec 11, 2024
9 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_20240926_update_chatglmv2 branch December 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants