Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Readme] Add flash mask #9219

Merged
merged 4 commits into from
Oct 25, 2024
Merged

[Readme] Add flash mask #9219

merged 4 commits into from
Oct 25, 2024

Conversation

lugimzzz
Copy link
Contributor

PR types

New features

PR changes

Others

Description

新增flashmask使用示例脚本

Copy link

paddle-bot bot commented Sep 30, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@ZHUI ZHUI changed the title add flash mask [Readme] Add flash mask Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.92%. Comparing base (0289118) to head (0570433).
Report is 48 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9219      +/-   ##
===========================================
- Coverage    52.96%   52.92%   -0.04%     
===========================================
  Files          656      660       +4     
  Lines       106258   106870     +612     
===========================================
+ Hits         56282    56565     +283     
- Misses       49976    50305     +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,92 @@
# FlashMask
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议放到llm/readme里,能力列表里增加一列,说明flashmask支持情况

@GuoxiaWang
Copy link
Contributor

是不是专门弄个 FlashMask 的页面,FlashMask 不仅仅是给 Llama 支持的,只是现在只子 Llama 上适配了。如过 Attention 那个方法是个基础函数,可以给 Transformer based 的模型调用,那就是通用的了。

Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrownFish19 DrownFish19 merged commit 81ffc78 into PaddlePaddle:develop Oct 25, 2024
10 of 12 checks passed
@lugimzzz lugimzzz deleted the flash branch December 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants