[LLM INFER] Fix some bugs and chatglm_v2 support block_attn #9271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9271 +/- ##
===========================================
+ Coverage 52.80% 52.89% +0.08%
===========================================
Files 660 660
Lines 106869 106929 +60
===========================================
+ Hits 56434 56561 +127
+ Misses 50435 50368 -67 ☔ View full report in Codecov by Sentry. |
yuanlehome
force-pushed
the
test_chatglm2
branch
from
f3b2d99 to
7551730
Compare
yuanlehome
changed the title
qingqing01
approved these changes
Oct 25, 2024
ZHUI
reviewed
Oct 25, 2024
| else: | ||
| return 8192 # Maximum sequence length. | ||
| total_max_length: int = field( | ||
| default=4096, metadata={"help": "Super parameter. Maximum sequence length(encoder+decoder)."} |
| @@ -520,7 +520,7 @@ def _preprocess(self, source): | |||
| alibi_slopes = llm_utils.get_alibi_slopes(self.model_config.n_head) | |||
| inputs["position_ids"] = paddle.to_tensor(alibi_slopes, dtype="float32") | |||
| arange_tensor_encoder = paddle.arange(self.config.total_max_length, dtype=self.config.dtype) | |||
| alibi = alibi_slopes[None, :, None, None] * arange_tensor_encoder | |||
| alibi = (alibi_slopes[None, :, None, None] * arange_tensor_encoder).astype(self.config.dtype) | |||
|
|
|||
There was a problem hiding this comment.
emm,这个 config dtype保险吗？用户可以改这个值。要不用里面一个tensor的dtype。
There was a problem hiding this comment.
这个dtype确实需要与config.dtype保持一致的
|
|
||
| model = Model.from_pretrained( | ||
| predictor_args.total_max_length = config.seq_length | ||
| if predictor_args.block_attn: |
There was a problem hiding this comment.
emm，我建议吧 block_attn 放到config的属性里面，然后 ChatGLMv2InferenceModel 里面自己控制。
这里改的话，后期这样修改的模型太多了。
There was a problem hiding this comment.
但严格来说其实这个不属于每个模型的Config，如果加入如LlamaConfig的话，每个模型的Config里都需要加，先保持这样吧，后面重构的时候，会看下有没有更好的方式
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Models
Description