[intel_hpu] initial commit for intel_hpu support #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_intel_hpu_backend
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9273 +/- ##
===========================================
+ Coverage 52.81% 52.91% +0.09%
===========================================
Files 673 673
Lines 107657 107687 +30
===========================================
+ Hits 56857 56980 +123
+ Misses 50800 50707 -93 ☔ View full report in Codecov by Sentry. |
DrownFish19
reviewed
Oct 15, 2024
yanfeich
force-pushed
the
support_intel_hpu_backend
branch
from
bcaf5f3 to
d9a3ad6
Compare
|
可以新建一个 llm/intel_hpu 放对应的运行示例和文档。 |
DrownFish19
reviewed
Oct 22, 2024
| @@ -248,7 +248,11 @@ def scaled_dot_product_attention( | |||
| value_states = paddle.transpose(value_states, [0, 2, 1, 3]) | |||
|
|
|||
| # matmul and devide by sqrt(head_dim) | |||
| attn_weights = paddle.matmul(query_states / math.sqrt(head_dim), key_states.transpose([0, 1, 3, 2])) | |||
| if get_env_device() == "intel_hpu": | |||
| attn_weights = paddle.matmul(query_states * (1 / math.sqrt(head_dim)), key_states.transpose([0, 1, 3, 2])) | |||
There was a problem hiding this comment.
这里的写法最好增加注释，说明为什么需要 1 / math.sqrt(head_dim。
| if config.context_parallel_degree > 1: | ||
| raise ValueError("Context parallel is not implemented for intel_hpu") | ||
| scaling_factor = query_states.shape[3] ** -0.5 | ||
| attention_mask = attention_mask.astype("bfloat16") |
There was a problem hiding this comment.
intel_hpu是否支持float16？facebook/llama-7b的数据类型是float16，llama2和llama3是bfloat16
可以参考 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Models
PR Category
Custom Device
Description
add intel_hpu device in PaddleNLP for fused RoPE, fused RMS, fused SDPA, dtype specific support