-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] SFTTrainer SFTConfig #9318
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9318 +/- ##
===========================================
- Coverage 53.09% 53.07% -0.02%
===========================================
Files 699 699
Lines 110471 110348 -123
===========================================
- Hits 58651 58569 -82
+ Misses 51820 51779 -41 ☔ View full report in Codecov by Sentry. |
|
return fn | ||
|
||
return docstring_decorator | ||
from paddlenlp.trainer.utils.doc import add_start_docstrings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
预训练的config没有考虑到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你说预训练的这部分也重构进入到主库吗?
@@ -0,0 +1,102 @@ | |||
# Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里放到paddlenlp library我想到的一个问题是,如果用户想新增相关的参数就必须要改动library,因此最近developllm工具必须适配最新的library,看起来会导致一些兼容问题。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以引导 用户使用
- 正式版lib + 正式版 llm
- dev lib + dev llm
不要混用。
实际是上,大部分更新的参数,用户并不会使用到。
PR types
Others
PR changes
Others
Description
Others