Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] SFTTrainer SFTConfig #9318

Merged
merged 20 commits into from
Nov 28, 2024
Merged

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Oct 25, 2024

PR types

Others

PR changes

Others

Description

Others

Copy link

paddle-bot bot commented Oct 25, 2024

Thanks for your contribution!

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 79.87421% with 32 lines in your changes missing coverage. Please review.

Project coverage is 53.07%. Comparing base (3ef14dc) to head (6356a56).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trl/sft_config.py 45.00% 22 Missing ⚠️
paddlenlp/trl/utils.py 0.00% 9 Missing ⚠️
paddlenlp/datasets/dataset.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9318      +/-   ##
===========================================
- Coverage    53.09%   53.07%   -0.02%     
===========================================
  Files          699      699              
  Lines       110471   110348     -123     
===========================================
- Hits         58651    58569      -82     
+ Misses       51820    51779      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gongel
❌ ZHUI
You have signed the CLA already but the status is still pending? Let us recheck it.

return fn

return docstring_decorator
from paddlenlp.trainer.utils.doc import add_start_docstrings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预训练的config没有考虑到

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你说预训练的这部分也重构进入到主库吗?

@@ -0,0 +1,102 @@
# Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里放到paddlenlp library我想到的一个问题是,如果用户想新增相关的参数就必须要改动library,因此最近developllm工具必须适配最新的library,看起来会导致一些兼容问题。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以引导 用户使用

  1. 正式版lib + 正式版 llm
  2. dev lib + dev llm

不要混用。

实际是上,大部分更新的参数,用户并不会使用到。

@ZHUI ZHUI merged commit 5926c30 into PaddlePaddle:develop Nov 28, 2024
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants