[Tokenizer] Add BertTokenizerFast, support register new tokenizer #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lvdongyi
changed the title
DrownFish19
reviewed
Nov 4, 2024
|
|
||
| # it is expected that each Chinese character is not preceded by "##" | ||
| self.assertListEqual(tokens_without_spe_char_p, list_of_commun_chinese_char) | ||
| self.assertListEqual(tokens_without_spe_char_r, list_of_commun_chinese_char) | ||
|
|
||
| # not yet supported in bert tokenizer |
There was a problem hiding this comment.
后边还有一些测试，是无法通过吗？我看现在bert tokenizer是支持对应参数的
|
注意没有单测的代码，需要添加单测进行覆盖 |
|
Lint 问题需要安装pre-commit 后格式化代码，参考步骤如下： # 安装
pip install pre-commit
# 在项目文件夹下注册pre-commit，每次commit提交时都会格式化代码
pre-commit install
# 单独处理之前的代码文件
pre-commit run --file XXXX.py |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9353 +/- ##
===========================================
+ Coverage 52.24% 53.12% +0.88%
===========================================
Files 673 674 +1
Lines 109100 107428 -1672
===========================================
+ Hits 56998 57073 +75
+ Misses 52102 50355 -1747 ☔ View full report in Codecov by Sentry. |
DrownFish19
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Models
Description
BertTokenizerFast, support converting a slow bert tokenizer instance in a fast tokenizer instance, add tests forBertTokenizerFastTOKENIZER_MAPPING, add tests for it.