Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix row parallel lora layers parameters initialization bug #9426

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Fix row parallel lora layers parameters initialization bug #9426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13dfca3
Fix row parallel lora layers parameters initialization bug
will-jl944 Nov 14, 2024
e80f96a
Fix ColumnParallel LoRA layers
will-jl944 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 44 additions & 34 deletions paddlenlp/peft/lora/lora_layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

import math
from contextlib import nullcontext
from typing import Optional

import paddle
Expand All @@ -22,6 +23,7 @@
from paddle.distributed.fleet.meta_parallel import (
ColumnParallelLinear,
RowParallelLinear,
get_rng_state_tracker,
)

try:
Expand Down Expand Up @@ -54,6 +56,10 @@ class RowSequenceParallelLinear:
from .lora_quick_layers import quick_lora


def rng_ctx(is_mp: bool, in_dynamic_mode: bool):
return get_rng_state_tracker().rng_state() if (is_mp and in_dynamic_mode) else nullcontext()


class LoRALinear(nn.Linear):
# LoRA implemented in a dense layer
def __init__(
Expand Down Expand Up @@ -202,14 +208,15 @@ def __init__(
self.name = self._name

# Actual trainable parameters
self.lora_A = self.create_parameter(
shape=[self.input_size_per_partition, r],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=nn.initializer.KaimingUniform(negative_slope=math.sqrt(5), nonlinearity="leaky_relu")
),
)
with rng_ctx(self.is_mp, paddle.in_dynamic_mode()):
self.lora_A = self.create_parameter(
shape=[self.input_size_per_partition, r],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=nn.initializer.KaimingUniform(negative_slope=math.sqrt(5), nonlinearity="leaky_relu")
),
)
self.lora_B = self.create_parameter(
shape=[r, self.out_features],
dtype=self._dtype,
Expand Down Expand Up @@ -349,14 +356,15 @@ def __init__(
self.name = self._name

# Actual trainable parameters
self.lora_A = self.create_parameter(
shape=[self.input_size_per_partition, r],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=nn.initializer.KaimingUniform(negative_slope=math.sqrt(5), nonlinearity="leaky_relu")
),
)
with rng_ctx(self.is_mp, paddle.in_dynamic_mode()):
self.lora_A = self.create_parameter(
shape=[self.input_size_per_partition, r],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=nn.initializer.KaimingUniform(negative_slope=math.sqrt(5), nonlinearity="leaky_relu")
),
)
self.lora_B = self.create_parameter(
shape=[r, self.out_features],
dtype=self._dtype,
Expand Down Expand Up @@ -472,15 +480,16 @@ def __init__(
attr=lora_A_weight_attr,
)
self.lora_A.is_distributed = False
self.lora_B = self.create_parameter(
shape=[r, self.output_size_per_partition],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=paddle.nn.initializer.Constant(value=0.0),
learning_rate=lora_plus_scale,
),
)
with rng_ctx(self.is_mp, paddle.in_dynamic_mode()):
self.lora_B = self.create_parameter(
shape=[r, self.output_size_per_partition],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=paddle.nn.initializer.Constant(value=0.0),
learning_rate=lora_plus_scale,
),
)

self.lora_B.is_distributed = True
self.lora_B.split_axis = 1
Expand Down Expand Up @@ -603,15 +612,16 @@ def __init__(
self.lora_A.is_distributed = False
mark_as_sequence_parallel_parameter(self.lora_A)

self.lora_B = self.create_parameter(
shape=[r, self.output_size_per_partition],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=paddle.nn.initializer.Constant(value=0.0),
learning_rate=lora_plus_scale,
),
)
with rng_ctx(self.is_mp, paddle.in_dynamic_mode()):
self.lora_B = self.create_parameter(
shape=[r, self.output_size_per_partition],
dtype=self._dtype,
is_bias=False,
attr=paddle.ParamAttr(
initializer=paddle.nn.initializer.Constant(value=0.0),
learning_rate=lora_plus_scale,
),
)

self.lora_B.is_distributed = True
self.lora_B.split_axis = 1
Expand Down
Loading