Fix row parallel lora layers parameters initialization bug #9427
+44
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9427 +/- ##
===========================================
+ Coverage 52.82% 52.91% +0.09%
===========================================
Files 676 676
Lines 107910 107926 +16
===========================================
+ Hits 57001 57107 +106
+ Misses 50909 50819 -90 ☔ View full report in Codecov by Sentry. |
JunnYu
reviewed
Nov 14, 2024
paddlenlp/peft/lora/lora_layers.py
Outdated
Comment on lines
202
to
204
| if self.is_mp and paddle.in_dynamic_mode(): | ||
| with get_rng_state_tracker().rng_state(): | ||
| self.lora_A = self.create_parameter( |
There was a problem hiding this comment.
不要写两个if else 代码太冗余了, 直接 import contextlib ctx = contextlib.nullcontext() if xxx else get_rng_state_tracker().rng_state()
gongel
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Models
Description
Fix the bug that in row-parallel LoRA layers, without
get_rng_state_tracker().rng_state()specified, shards of LoRA A are initialized identically among all devices in MP group. Please refer to how the parameter is initialized inpaddle.distributed.fleet.meta_parallel.RowParallelLinear.