[Embedding] Add embedding training #9508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
DesmonDay
commented
Nov 27, 2024
paddlenlp/trainer/trainer.py
Outdated
| @@ -1093,9 +1093,9 @@ def _inner_training_loop( | |||
| if is_no_sync: | |||
| # Avoid unnecessary DDP synchronization since there will be no backward pass on this example. | |||
| with model.no_sync(): | |||
| tr_loss_step = self.training_step(model, inputs) | |||
| tr_loss_step = self.training_step(model, inputs, step_control=step_control) | |||
There was a problem hiding this comment.
这里要兼容，判断 self.training_step 有没有 step_control 参数
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9508 +/- ##
===========================================
- Coverage 52.77% 52.71% -0.07%
===========================================
Files 709 710 +1
Lines 111172 111417 +245
===========================================
+ Hits 58674 58733 +59
- Misses 52498 52684 +186 ☔ View full report in Codecov by Sentry. |
…er' into dev_20241121_add_qwen2_embedding
…d_qwen2_embedding
|
|
DesmonDay
force-pushed
the
add_embedding_trainer
branch
from
20f56e6 to
ba2c286
Compare
DesmonDay
force-pushed
the
add_embedding_trainer
branch
from
7964ad3 to
d815fce
Compare
ZHUI
reviewed
Dec 6, 2024
llm/config/qwen/emb_argument.json
Outdated
| "max_query_len": 1024, | ||
| "max_passage_len": 2048, | ||
| "group_size": 4, | ||
| "bp16": true, |
| model_config.embedding_negatives_cross_device = embedding_args.embedding_negatives_cross_device | ||
| logger.info(f"Final model config: {model_config}") | ||
|
|
||
| model_class = Qwen2SentenceEmbedding |
Comment on lines
+264
to
+265
| trainable_parameters = [p for p in model.parameters() if not p.stop_gradient] | ||
| trainer.set_optimizer_grouped_parameters(trainable_parameters) |
paddlenlp/trainer/trainer.py
Outdated
| @@ -1093,9 +1093,9 @@ def _inner_training_loop( | |||
| if is_no_sync: | |||
| # Avoid unnecessary DDP synchronization since there will be no backward pass on this example. | |||
| with model.no_sync(): | |||
| tr_loss_step = self.training_step(model, inputs) | |||
| tr_loss_step = self.training_step(model, inputs, step_control=step_control) | |||
There was a problem hiding this comment.
这里要兼容，判断 self.training_step 有没有 step_control 参数
DesmonDay
force-pushed
the
add_embedding_trainer
branch
2 times, most recently
from
1328048 to
63ba9d0
Compare
DesmonDay
force-pushed
the
add_embedding_trainer
branch
from
63ba9d0 to
0a618b0
Compare
…nto add_embedding_trainer
ZHUI
reviewed
Dec 11, 2024
| # Detecting last checkpoint. | ||
| last_checkpoint = None | ||
| if os.path.isdir(training_args.output_dir) and training_args.do_train and not training_args.overwrite_output_dir: | ||
| last_checkpoint = get_last_checkpoint(training_args.output_dir) |
…nto add_embedding_trainer
DesmonDay
changed the title
ZHUI
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Support embedding training.