[llm]add adam-mini #9542
Merged
[llm]add adam-mini #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lugimzzz
commented
Dec 2, 2024
| @@ -0,0 +1 @@ | |||
| ../../../../llm/docs/predict/speculative_decoding.md | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9542 +/- ##
===========================================
- Coverage 53.10% 53.03% -0.07%
===========================================
Files 704 704
Lines 110967 110878 -89
===========================================
- Hits 58925 58809 -116
- Misses 52042 52069 +27 ☔ View full report in Codecov by Sentry. |
wawltor
reviewed
Dec 4, 2024
| from ..utils import AdamWMini | ||
|
|
||
| optimizer_cls = AdamWMini | ||
| optimizer_kwargs.update(adam_kwargs) |
There was a problem hiding this comment.
这里是否可以做一些限制或者提示，例如tp、sharding情况下不能开启 AdamWMini
| @@ -0,0 +1,53 @@ | |||
| # Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
| # | |||
paddlenlp/utils/optimizer.py
Outdated
| def _add_moments_pows(self, p): | ||
| acc_dtype = p.dtype | ||
| if self._is_dtype_fp16_or_bf16(acc_dtype): | ||
| acc_dtype = DataType.FLOAT32 if in_pir_mode() else core.VarDesc.VarType.FP32 |
There was a problem hiding this comment.
目前框架中都统一到 paddle.xxx 的dtype，可以参考下 https://github.com/PaddlePaddle/PaddleNLP/pull/9366/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
新增 adam-mini，训练过程新增--optim "adamw_mini"，暂时不支持unified checkpoint存储
TP暂不支持，moment2计算需要进行gather