adapt code to amsgrad supported adamw #9568
Merged
+61
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9568 +/- ##
===========================================
+ Coverage 52.83% 52.95% +0.11%
===========================================
Files 701 701
Lines 110577 110577
===========================================
+ Hits 58427 58551 +124
+ Misses 52150 52026 -124 ☔ View full report in Codecov by Sentry. |
DrownFish19
reviewed
Dec 5, 2024
| # support amsgrad: https://github.com/PaddlePaddle/Paddle/pull/68079 | ||
| self.support_amsgrad = ( | ||
| "amsgrad" in inspect.signature(paddle.optimizer.AdamW.__init__).parameters | ||
| ) |
There was a problem hiding this comment.
这种写法是默认amsgrad吗？
不，这个support_amsgrad的意思是说当前paddle是否支持amsgrad，因为支持amsgrad后，adam/adamw的C_ops接口有变动，位置参数发生变化，所以需要用这个flag表示当前运行的paddle是amsgrad之前的还是之后的。是否启用amsgrad是根据 self._amsgrad 决定的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
在PaddlePaddle/Paddle#68079中对adam/adamw新增了amsgrad参数，但是对于
_C_ops的直调行为是不兼容升级，因此对代码进行适配