Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 7th No.43】完善 TokenizerFast 功能支持 part 5 #9594

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

yinfan98
Copy link
Contributor

@yinfan98 yinfan98 commented Dec 9, 2024

PR types

New features

PR changes

Others

Description

添加Ernie TokenizerFast
Reference:https://github.com/rogerdehe/transformers-ernie/tree/main

Copy link

paddle-bot bot commented Dec 9, 2024

Thanks for your contribution!

@yinfan98
Copy link
Contributor Author

yinfan98 commented Dec 9, 2024

cc:@DrownFish19

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.05%. Comparing base (b205922) to head (2d73627).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/ernie/tokenizer_fast.py 72.72% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9594      +/-   ##
===========================================
+ Coverage    52.74%   53.05%   +0.31%     
===========================================
  Files          708      709       +1     
  Lines       111166   111601     +435     
===========================================
+ Hits         58629    59215     +586     
+ Misses       52537    52386     -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yinfan98
Copy link
Contributor Author

@DrownFish19 CI看起来都过了哈,麻烦再帮忙review下~

Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrownFish19 DrownFish19 merged commit f445a7a into PaddlePaddle:develop Dec 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants