Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add onnxruntime inference #1743

Merged
merged 8 commits into from
Feb 13, 2022
Merged

[Feature] Add onnxruntime inference #1743

merged 8 commits into from
Feb 13, 2022

Conversation

xmba15
Copy link
Contributor

@xmba15 xmba15 commented Jan 22, 2022

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@xmba15
Copy link
Contributor Author

xmba15 commented Jan 22, 2022

just incase, I put here the converted onnx model of bisenetv2_cityscapes
bisenetv2_cityscapes.zip

@xmba15 xmba15 mentioned this pull request Jan 22, 2022
Closed
@xmba15 xmba15 force-pushed the onnxruntime_cpp branch 5 times, most recently from f9695af to 2d897d7 Compare January 23, 2022 05:11
@michaelowenliu michaelowenliu changed the title Onnxruntime cpp [Feature] Add Onnxruntime inference Jan 24, 2022
@michaelowenliu michaelowenliu changed the title [Feature] Add Onnxruntime inference [Feature] Add onnxruntime inference Jan 24, 2022
@michaelowenliu michaelowenliu added the contributor Contribution from developers label Jan 24, 2022
@michaelowenliu michaelowenliu linked an issue Jan 24, 2022 that may be closed by this pull request
contribution of a PaddleSeg onnxruntime C++ sample #1714
Closed
juncaipeng
juncaipeng reviewed Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again and I leave some comments. @xmba15

deploy/onnxruntime_cpp/src/test_seg.cpp Outdated Show resolved Hide resolved
deploy/onnxruntime_cpp/src/test_seg.cpp Outdated Show resolved Hide resolved
deploy/onnxruntime_cpp/README.md Show resolved Hide resolved
deploy/onnxruntime_cpp/README.md Show resolved Hide resolved
deploy/onnxruntime_cpp/README.md Outdated Show resolved Hide resolved
@xmba15
Copy link
Contributor Author

xmba15 commented Jan 30, 2022

@juncaipeng Sorry for the late reply. I added modifications accordingly to the reviews. Please have a check.

@xmba15
Copy link
Contributor Author

xmba15 commented Jan 30, 2022 •
edited
Loading

@juncaipeng PaddleSeg_CI_Codestyle (PaddleSeg_CI) seemed to fail but I could not see the logs to see what should be changed. Can you please take a look at it also?

@xmba15
Copy link
Contributor Author

xmba15 commented Feb 12, 2022

@juncaipeng @michaelowenliu Can you please check? Sorry for this reminder though, I know the team must have been busy.

@juncaipeng
Copy link
Collaborator

@xmba15 Sorry for my late reply too, we have a holiday of Chinese new year.
The PR is LGTM.

juncaipeng
juncaipeng approved these changes Feb 13, 2022
View reviewed changes
Copy link
Collaborator

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juncaipeng juncaipeng merged commit c1d8ba5 into PaddlePaddle:develop Feb 13, 2022
@juncaipeng
Copy link
Collaborator

Thank you again. @xmba15

@shiyutang shiyutang removed the contributor Contribution from developers label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juncaipeng juncaipeng juncaipeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contribution of a PaddleSeg onnxruntime C++ sample
5 participants
@xmba15 @CLAassistant @juncaipeng @michaelowenliu @shiyutang