Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add MobileSAM #3349

Merged
merged 8 commits into from
Jul 31, 2023

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Jun 30, 2023

PR types

New features

PR changes

Models

Description

Add MobileSAM
fix #3346

Vit-T 预测结果如下:
image

@shiyutang shiyutang self-requested a review July 3, 2023 03:39
@shiyutang shiyutang added the contributor Contribution from developers label Jul 3, 2023
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要验证加载相同参数情况下,前向推理随机数输入和图片输入均和mobileSAM对齐。
  2. 另外模型参数可以给我链接上传。
  3. codestyle 没过,需要安装pre-commit:https://github.com/PaddlePaddle/PaddleSeg/blob/develop/docs/pr/pr/pr.md#4-use-pre-commit-hook; pre-commit run --all-files

contrib/SegmentAnything/scripts/amg_paddle.py Outdated Show resolved Hide resolved
contrib/SegmentAnything/scripts/amg_paddle.py Outdated Show resolved Hide resolved
contrib/SegmentAnything/scripts/promt_predict.py Outdated Show resolved Hide resolved
contrib/SegmentAnything/scripts/text_to_sam_clip.py Outdated Show resolved Hide resolved
@shiyutang
Copy link
Collaborator

如果修改好可以re-request review。

Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码验证完成,需要修改一些code style,并替换vit-t为下面的模型链接:https://paddleseg.bj.bcebos.com/dygraph/paddlesegAnything/vit_t/model.pdparam

contrib/SegmentAnything/scripts/amg_paddle.py Outdated Show resolved Hide resolved
shiyutang
shiyutang previously approved these changes Jul 30, 2023
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很棒,但是还有一些小改动,其他没有问题。

另外code style还是没有通过,也许需要到paddleseg根目录下进行code style的检查。

pre-commit run --files contrib/SegmentAnything/*

@shiyutang
Copy link
Collaborator

shiyutang commented Jul 31, 2023

image

pre-commit版本:3.3.1

Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor PR is Merged contributor Contribution from developers
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants