Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] add error code #1391

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

lym0302
Copy link
Contributor

@lym0302 lym0302 commented Jan 26, 2022

PR types
New features

PR changes
add error code

Describe
speech server
#1368
#1369

@lym0302 lym0302 added this to the r0.2.0 milestone Jan 26, 2022
@zh794390558 zh794390558 changed the title add error code, test=server [server] add error code Jan 26, 2022
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -22,6 +22,8 @@

from paddlespeech.cli.log import logger
from paddlespeech.cli.tts.infer import TTSExecutor
from utils.errors import ErrorCode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

想问下,utils是怎么import对应的路径的?

#if msg:
#log.error(msg)
msg = msg if msg else ErrorMsg.get(error_code, "")
super(ServerBaseException, self).__init__(error_code, msg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面都统一修改成 super().init

@zh794390558 zh794390558 merged commit 1ee4577 into PaddlePaddle:server Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants