add with syntax #47
Merged
add with syntax #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Jan 2, 2018
visualdl/python/storage.py
Outdated
| return StorageReader.cur_mode | ||
|
|
||
| def __exit__(self, type, value, traceback): | ||
| pass |
There was a problem hiding this comment.
对，语法会干净点，理论上只是设置下 mode 作为tag的前缀
daming-lu
previously approved these changes
Jan 2, 2018
daming-lu
approved these changes
Jan 2, 2018
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 12, 2018
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.