Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support some tool demo #50

Merged

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jan 2, 2018

  • scalar sample 100 pointers
  • image will be resized to 80 size
  • bug fix

@Superjomn Superjomn changed the title Feature/support pytorch demo Feature/support some tool demo Jan 2, 2018
@jacquesqiao
Copy link
Member

what is tool demo?

@@ -51,7 +50,7 @@ def option_parser():
static_file_path = "./frontend/dist/"
mock_data_path = "./mock_data/"

storage = storage.StorageReader(options.logdir)
storage = storage.LogReader(options.logdir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_reader is better then storage

@@ -68,7 +68,7 @@ static void NormalizeImage(Uint8Image* image,
offset = 0.0f;
}

LOG(INFO) << "scale " << scale;
// LOG(INFO) << "scale " << scale;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm unused line

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Superjomn Superjomn merged commit 9444f05 into PaddlePaddle:develop Jan 3, 2018
@Superjomn Superjomn deleted the feature/support_pytorch_demo branch January 3, 2018 08:01
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 12, 2018
jacquesqiao added a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
jacquesqiao pushed a commit to jacquesqiao/VisualDL that referenced this pull request Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants