Fixed some compilation errors and unit test failure #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* link in eigen3 library to vl_test target * Add new "template class SimpleWriteSyncGuard<Entry<long long>>;", since build will fail on OSX * Add template keyboard to data<T>(0).Get() (otherwise this fails on OSX) * Fix unit test in sdk_test.cc Tested build and unit test run on OSX and Ubuntu with no issues
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 12, 2018
Fixed some compilation errors and unit test failure
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
Update README.md
jacquesqiao
pushed a commit
to jacquesqiao/VisualDL
that referenced
this pull request
Jan 13, 2018
Fixed some compilation errors and unit test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested build and unit test run on OSX and Ubuntu with no issues