Enable ingress notebook access #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
reviewed
Jul 17, 2017
Yancey1989
reviewed
Jul 17, 2017
paddlecloud/notebook/utils.py
Outdated
| @@ -72,7 +72,7 @@ class UserNotebook(): | |||
| "name": "cloud-notebook", | |||
| "image": settings.PADDLE_BOOK_IMAGE, | |||
| "command": ["sh", "-c", | |||
| "mkdir -p /root/.jupyter; echo \"c.NotebookApp.base_url = '/notebook/%s'\" > /root/.jupyter/jupyter_notebook_config.py; jupyter notebook --debug --ip=0.0.0.0 --no-browser --allow-root --NotebookApp.token='' --NotebookApp.disable_check_xsrf=True /book/"], | |||
| "mkdir -p /root/.jupyter; echo \"c.NotebookApp.base_url = '/notebook/%s'\" > /root/.jupyter/jupyter_notebook_config.py; echo \"c.NotebookApp.allow_origin = '*'\" >> /root/.jupyter/jupyter_notebook_config.py; jupyter notebook --debug --ip=0.0.0.0 --no-browser --allow-root --NotebookApp.token='' --NotebookApp.disable_check_xsrf=True /book/"], | |||
There was a problem hiding this comment.
Maybe we do not use the debug flag?
Yancey1989
added a commit
that referenced
this pull request
Jul 23, 2017
* tutorial and usage update * first add * rm not need * fix bugs * add logging * add docker file * fix by yancey's comment * update * save parameter * fix yaml * fix bugs * fix bugs * fix convert bug * fix by wuyi's comment * add readme * rm logging.confg * modify README.md * modify README.md * add start command * update * update by comments * upload files with recursion * prettify output * remove replica set name * recursion to loop * dlnel index page (#194) * switch to dlnel index page * mount template files * delete unused comments * add port env * update tutorial (#202) * update tutorial * update * remove unused line * update * update * update * test format * modify travis.yaml * fix * fix * fix sudo * add travis * add glide * add gimme * fix style * fix style * add files * modify sh * fix by wuyi's comments * fix pre-commit bugs * Format quota print (#205) * forat quota print * update * add sleep for pserver get ready (#216) * Update readme (#214) * update readme * update * Enable ingress notebook access (#219) * enable ingress notebook access * update notebook resource * test ok * fix * fix * fix login url (#229) * Fix invalid job path (#227) * fix invalid job path * update doc * check job name in clint (#231) * [Done]Fault tolerant job (#212) * fault tolerant job * ft job * update * tested job submit with ft job * update
Yancey1989
added a commit
that referenced
this pull request
Jul 23, 2017
* tutorial and usage update * first add * rm not need * fix bugs * add logging * add docker file * fix by yancey's comment * update * save parameter * fix yaml * fix bugs * fix bugs * fix convert bug * fix by wuyi's comment * add readme * rm logging.confg * modify README.md * modify README.md * add start command * update * update by comments * upload files with recursion * prettify output * remove replica set name * recursion to loop * dlnel index page (#194) * switch to dlnel index page * mount template files * delete unused comments * add port env * update tutorial (#202) * update tutorial * update * remove unused line * update * update * update * test format * modify travis.yaml * fix * fix * fix sudo * add travis * add glide * add gimme * fix style * fix style * add files * modify sh * fix by wuyi's comments * fix pre-commit bugs * Format quota print (#205) * forat quota print * update * add sleep for pserver get ready (#216) * Update readme (#214) * update readme * update * Enable ingress notebook access (#219) * enable ingress notebook access * update notebook resource * test ok * fix * fix * fix login url (#229) * Fix invalid job path (#227) * fix invalid job path * update doc * check job name in clint (#231) * [Done]Fault tolerant job (#212) * fault tolerant job * ft job * update * tested job submit with ft job * update * fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.