Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add demo for fault tolerant label semantic role and machine translation. #300

Merged
merged 2 commits into from
Aug 14, 2017
Merged

Add demo for fault tolerant label semantic role and machine translation. #300

merged 2 commits into from
Aug 14, 2017

Conversation

helinwang
Copy link
Collaborator

No description provided.

Yancey1989
Yancey1989 previously approved these changes Aug 14, 2017
View reviewed changes
Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

demo/label_semantic_roles/train_ft.py Outdated
import paddle.v2.evaluator as evaluator
from paddle.v2.reader.creator import cloud_reader

master_ip = os.getenv("MASTER_IP")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #278 has already merged, we can use environment variable ETCD_IP instead of MASTER_IP.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! Done.

demo/machine_translation/train_ft.py Outdated
import paddle.v2 as paddle
from paddle.v2.reader.creator import cloud_reader

master_ip = os.getenv("MASTER_IP")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MASTER_IP => ETCD_IP

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

@helinwang helinwang merged commit 73ade55 into PaddlePaddle:develop Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@Yancey1989 Yancey1989 Yancey1989 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helinwang @Yancey1989 @wangkuiyi