【Hackathon No.37】为 Paddle 优化 argmin_argmax op 在 GPU 上的计算性能 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzSean
reviewed
Sep 16, 2022
|
|
||
| ## 1.1 飞桨现状 | ||
|
|
||
| 当前性能如下表(基于ＰaddleＰaddle develop分支)： |
|
|
||
| ## 1.3 对比分析 | ||
|
|
||
| 目前Paddle与Pytorch的API设计方案几乎相同, 且底层都使用了Cub库实现。 |
There was a problem hiding this comment.
这个能解释为什么pytorch底层也用了cub但是性能差异这么大吗？如果使用reduce改写，预计性能提升4.5倍后，跟pytorch还是有比较大的差距
There was a problem hiding this comment.
@ZzSean 发现paddle和pytorch实现上除了cub外，还有其他细节有些差异，已补充rfc。如果有遗漏的地方，辛苦老师多指点一下。
There was a problem hiding this comment.
@ZzSean 经测试fastdivmod并没有明显性能提升，block优化配置后有较明显提升但是离pytorch性能差距还比较大，重新研读了torch代码，发现新版torch底层用的reduce。
ZzSean
reviewed
Sep 26, 2022
| [1]. [OP Benchmark使用指南](https://github.com/PaddlePaddle/benchmark/blob/master/api/README.md) | ||
|
|
||
|
|
||
| PPYDDDD111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
提交argmin_argmax OP性能优化设计文档