Fix inconsistency between poisson_nll_loss rfc and implementation #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGBond8488
reviewed
Mar 29, 2023
| @@ -46,20 +46,20 @@ PyTorch：PyTorch 支持 torch.nn.poissonNLLLoss 和 torch.nn.functional.Poisson | |||
| ```python | |||
| def poisson_nll_loss( | |||
| input: Tensor, | |||
| target: Tensor, | |||
| label: Tensor, | |||
| log_input: bool = True, | ||
| full: bool = False, | ||
| size_average: Optional[bool] = None, | ||
| epsilon: float = 1e-8, | ||
| reduce: Optional[bool] = None, | ||
| reduction: str = "mean", | ||
| ) -> Tensor: | ||
| if has_torch_function_variadic(input, target): | ||
| if has_torch_function_variadic(input, label): |
LyndonKong
force-pushed
the
fix_poisson_nll_loss
branch
from
991b27f
to
923f553
Compare
luotao1
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the suggesstions of our kind reviewer, we update our rfc doc. Refer to this pr